Add missing deps and fix device bug

[aknierim]

Small PR to fix missing cartopy and mergedeep dependencies introduced in #50.
Also fixes Gridder.from_pyvisgen to ensure that vis_data is a numpy array when obtained from pyvisgen.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.45%. Comparing base (c00a355) to head (b399af7).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/pyvisgrid/core/gridder.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #72       +/-   ##
===========================================
+ Coverage   39.25%   50.45%   +11.20%     
===========================================
  Files          10        9        -1     
  Lines         912      660      -252     
===========================================
- Hits          358      333       -25     
+ Misses        554      327      -227     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[tgross03]

cartopy and mergedeep seem to be used only in the animations module, which is an optional dependency. Should they really be mandatory dependencies?

[aknierim]

cartopy and mergedeep seem to be used only in the animations module, which is an optional dependency. Should they really be mandatory dependencies?

Then the code should treat them as such. For now, whenever one tries to plot something, one would get an ImportError. I can change the code so it is optional if you like

[tgross03]

Then the code should treat them as such. For now, whenever one tries to plot something, one would get an ImportError. I can change the code so it is optional if you like

Ah, I see I missed the import in the __init__.py of the plotting module. If you have time to fix this, that would be nice.

[aknierim]

Then the code should treat them as such. For now, whenever one tries to plot something, one would get an ImportError. I can change the code so it is optional if you like

Ah, I see I missed the import in the __init__.py of the plotting module. If you have time to fix this, that would be nice.

That one, right? I'll remove it :)

pyvisgrid/src/pyvisgrid/plotting/__init__.py

Line 14 in c00a355

"animate_observation",

[tgross03]

That one, right? I'll remove it :)

pyvisgrid/src/pyvisgrid/plotting/__init__.py

Line 14 in c00a355

"animate_observation",

All of the functions imported from pyvisgrid.plotting.animations will create problems because cartopy and mergedeep are imported at the top of the animations.py file.

Thus have to check whether pyvisgrid.plotting.animations can be imported and then add the functions to the __all__ variable or we have to remove all of the animations functions from __init__.py.

[aknierim]

That one, right? I'll remove it :)

pyvisgrid/src/pyvisgrid/plotting/__init__.py

Line 14 in c00a355

"animate_observation",

All of the functions imported from pyvisgrid.plotting.animations will create problems because cartopy and mergedeep are imported at the top of the animations.py file.

Thus have to check whether pyvisgrid.plotting.animations can be imported and then add the functions to the __all__ variable or we have to remove all of the animations functions from __init__.py.

Ah, missed those two there, sorry, my bad. I think it's easier to remove them from module init for now.

[tgross03]

That one, right? I'll remove it :)

pyvisgrid/src/pyvisgrid/plotting/__init__.py

Line 14 in c00a355

"animate_observation",

All of the functions imported from pyvisgrid.plotting.animations will create problems because cartopy and mergedeep are imported at the top of the animations.py file.
Thus have to check whether pyvisgrid.plotting.animations can be imported and then add the functions to the __all__ variable or we have to remove all of the animations functions from __init__.py.

Ah, missed those two there, sorry, my bad. I think it's easier to remove them from module init for now.

Yeah, I also think that this is the easiest way but sadly it is potentially breaking for certain scripts that i.e. use from pyvisgrid.plotting import animate_observation.

[aknierim]

I mean, in that case you should install pyvisgrid via the [animations] optional dependencies anyway as intended, so I think that should not be too much of a problem