Log gh stderr on IssueTracker shell failures#172
Merged
dhilgaertner merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
The shell() and shellSync() helpers piped stderr to an unread Pipe() and threw NSError with no userInfo, so every gh failure logged as `Code=1 "(null)"` with no diagnostic info. Capture stderr and surface it via NSLocalizedDescriptionKey so existing catch-site prints render the real cause. Closes #170 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IssueTracker.shell()andshellSync()now captureghstderr and embed it in the thrownNSErrorviaNSLocalizedDescriptionKey, so existingprint("... failed: \(error)")call sites render the real failure cause instead ofCode=1 "(null)".gh authfailure → one-time notification is deferred per plan — log-first, then target the follow-up once real stderr patterns are known.Closes #170
Test plan
make buildsucceeds.ghfailure (e.g. temporarily move~/.config/gh), wait for a poll cycle, confirm[IssueTracker] ... failed:lines include the real stderr (HTTP 401,authentication required, etc.).🤖 Generated with Claude Code