Skip to content

Add directory icons: outline, filled, open and closed#142

Open
xDellTog wants to merge 1 commit into
radix-ui:mainfrom
xDellTog:master
Open

Add directory icons: outline, filled, open and closed#142
xDellTog wants to merge 1 commit into
radix-ui:mainfrom
xDellTog:master

Conversation

@xDellTog

@xDellTog xDellTog commented Oct 18, 2022

Copy link
Copy Markdown

Hi, I would like to contribute by adding 4 directory/folder icons:

  • Directory
  • DirectoryFilled
  • DirectoryOpen
  • DirectoryOpenFilled

Following this pull request (#96) pattern. I copied the Figma file, added the 4 icons in the Objects category, exported the SVG, implemented the React components based on the other Icons and added it to the website.

This closes the following Request: Folder / FolderFilled icon #84


PR checklist:

  • Figma: icon shapes use “Scale” constraint
  • Figma: icon components are sorted Z-A in the file
  • Figma: icon components are built with a single union or compound shape when possible
  • Figma: library changes are published
  • SVG: icons render correctly in a browser
  • SVG: icons are exported with width="15" height="15" viewBox="0 0 15 15"
  • SVG: no icons are exported with stroke
  • SVG: no icons are exported with clip-path
  • SVG: no icons exceed 5 KB
  • Website is up to date
  • Sketch file is up to date
  • IconJar file is up to date
    • Icon names in the IconJar library are correct
    • Version in the IconJar library description is correct

@vercel

vercel Bot commented Oct 18, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
radix-icons ❌ Failed (Inspect) Oct 18, 2022 at 5:06PM (UTC)

@gschier

gschier commented Nov 4, 2023

Copy link
Copy Markdown

Any status on this? Would love a folder icon

@paralin

paralin commented Nov 15, 2023

Copy link
Copy Markdown

I'm also severely missing the presence of a Folder icon within radix-ui/icons! Would love to see this.

@dantehemerson

Copy link
Copy Markdown

+1 on this, can you please merge it?

@gschier

gschier commented Feb 5, 2024

Copy link
Copy Markdown

I switched to Feather Icons and still found it to be lacking. So, I switched to Lucide (feather fork) that has everything I needed

@ruru-m07 ruru-m07 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@drfarrell

Copy link
Copy Markdown

Can we merge this in? Could use the folder icon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants