CheckboxGroup docs using wrong defaultValue type#890
Open
S-Axhwin wants to merge 1 commit intoradix-ui:mainfrom
Open
CheckboxGroup docs using wrong defaultValue type#890S-Axhwin wants to merge 1 commit intoradix-ui:mainfrom
S-Axhwin wants to merge 1 commit intoradix-ui:mainfrom
Conversation
|
@S-Axhwin is attempting to deploy a commit to the WorkOS Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #883
Description
The
CheckboxGroup.Rootexamples in/data/themes/docs/components/checkbox-group.mdxincorrectly passeddefaultValueas a string.The component API requires an array of strings.
This caused the live examples to render uncontrolled/incorrect states.
This PR updates all occurrences of:
to:
and fixes inconsistent
valueprops in the size examples.Checklist
Preview URL
https://website-git-checkbox-group-fix-s-axhwins-projects.vercel.app/themes/docs/components/checkbox-group