Open
Conversation
update build script
Android build
update scrip build ios
There was a problem hiding this comment.
Pull request overview
This PR adds GoMobile support to the libwallet project, enabling the library to be compiled and used on iOS and Android mobile platforms. The implementation creates a comprehensive wrapper layer that exposes wallet functionality through a mobile-friendly API.
Key changes include:
- Created a new
gomobilepackage with wrapper functions for wallet operations, transactions, syncing, and address management - Added automated build scripts for iOS (XCFramework) and Android (AAR) platforms
- Updated dependencies to include
golang.org/x/mobileand related tools
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools.go | Adds tool dependencies for gomobile and gobind commands |
| go.mod | Updates Go version and adds golang.org/x/mobile dependency along with transitive dependencies |
| go.sum | Updates dependency checksums for new and updated packages |
| gomobile/gomobile.go | Core initialization and shutdown functions for the mobile library |
| gomobile/types.go | Type definitions, constants, and request/response structures for mobile API |
| gomobile/walletloader.go | Wallet lifecycle management functions (create, load, close, seed retrieval, balance, passphrase change) |
| gomobile/transactions.go | Transaction-related functions (create, send, list, decode, estimate fees) |
| gomobile/sync.go | Synchronization functions and status reporting with SPV notification handlers |
| gomobile/addresses.go | Address management and cryptographic operations (generate, sign, verify) |
| gomobile/utils.go | Helper function for safely accessing loaded wallets |
| gomobile/log.go | Logging infrastructure with support for both file rotation and stdout |
| build_gomobile_ios.sh | Comprehensive iOS build script with device/simulator support and validation |
| build_gomobile_android.sh | Android build script for creating AAR packages with configurable SDK versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: