Skip to content

fix: modified curl commands for X-5 UAT#11

Merged
raskolnikoff merged 1 commit intomainfrom
design/execution-boundary-ownership
Feb 21, 2026
Merged

fix: modified curl commands for X-5 UAT#11
raskolnikoff merged 1 commit intomainfrom
design/execution-boundary-ownership

Conversation

@raskolnikoff
Copy link
Copy Markdown
Collaborator

This pull request updates the docs/uat/X5_Evidence_Attachment_UAT_Runbook.md to reflect changes in the API request and response structure for UAT scenarios. The main focus is on adding the request_id field to all request examples and updating the expected response fields and comparison logic to use the new structure.

API Request Updates:

  • Added the "request_id" field to all example request payloads to demonstrate its required presence in API calls. [1] [2] [3] [4] [5] [6] [7] [8]

API Response & Verification Updates:

  • Updated the verification checklist to expect a timestamp field (server-generated execution timestamp) instead of executed_at, and clarified the presence of request_id and result.
  • Modified the comparison instructions to exclude trace_id, timestamp, and execution_time_ms from diff checks, instead of the previous request_id and executed_at.

Copilot AI review requested due to automatic review settings February 21, 2026 01:31
@raskolnikoff raskolnikoff merged commit 2bc5753 into main Feb 21, 2026
2 checks passed
@raskolnikoff raskolnikoff deleted the design/execution-boundary-ownership branch February 21, 2026 01:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the X-5 manual UAT runbook to reflect the updated invoke API shape by including request_id in example requests and aligning the verification/comparison steps with the new response fields.

Changes:

  • Add request_id to all curl request payload examples.
  • Update verification expectations to use timestamp (instead of executed_at).
  • Update determinism diff instructions to ignore volatile response fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +181 to +182
jq 'del(.trace_id, .timestamp, .execution_time_ms)' r1.json > c1.json
jq 'del(.trace_id, .timestamp, .execution_time_ms)' r2.json > c2.json
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the determinism comparison, the two requests use different request_id values (req-005 vs req-006), and the response contract indicates request_id mirrors the request. As written, diff c1.json c2.json will almost certainly show a difference purely due to request_id. Update the jq filters to also remove request_id (and any other per-request identifiers present in the response) so the comparison actually validates deterministic output.

Suggested change
jq 'del(.trace_id, .timestamp, .execution_time_ms)' r1.json > c1.json
jq 'del(.trace_id, .timestamp, .execution_time_ms)' r2.json > c2.json
jq 'del(.trace_id, .timestamp, .execution_time_ms, .request_id, .session_id)' r1.json > c1.json
jq 'del(.trace_id, .timestamp, .execution_time_ms, .request_id, .session_id)' r2.json > c2.json

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants