Adding requirements.txt and edit README.md#6
Open
AmirRezaHamidi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tried to fix the way you explained how to run your code. Other people also mentioned that they had problems running your code. Check the Issues tab at the top of your repository.
1- First, your code does not work with modern versions of Python. I tried it, and it did not work. You need an older version of Python. I tested Python 3.8, and it worked. Maybe newer versions also work, but 3.8 was fine. Since it is an old version, not everyone has it installed, so they either need to downgrade their Python version or create an ENVIRONMENT. If you do not know what that is, search for Miniconda or Anaconda. It is basically an isolated environment that does not affect the rest of the packages on your computer. In other words, you can have multiple versions of Python on one computer, but in different environments.
2- I added the necessary guidelines for anyone to create an environment using Miniconda.
3- I added a
requirements.txtfile, which is the conventional way of installing packages. I also provided the necessary commands in yourREADME.mdfile showing how to use thisrequirements.txtfile with pip to install all of your packages (your dependencies, in other words) in just one command.4- This way, anyone who wants to run your code will first create an environment, second install the necessary packages, and third run your code without a problem.
THIS IS A PULL REQUEST, AND SINCE IT IS YOUR FIRST PULL REQUEST, DO NOT JUST ACCEPT IT, OTHERWISE YOUR README AND REPOSITORY WILL CHANGE. INSTEAD, CHECK THE CHANGES FIRST, AND IF YOU THINK THEY FIT, THEN ACCEPT IT.
Regards,
Some random programmer.