Open
Conversation
Support Double as input for Graphite Client
kirpigiller
suggested changes
Feb 18, 2019
| } | ||
|
|
||
| public void Send(string path, int value, DateTime timeStamp) | ||
| public void Send(string path, double value, DateTime timeStamp) |
There was a problem hiding this comment.
Probably, it would be better to save int-methods also
| public byte[] ToByteArray() | ||
| { | ||
| var line = string.Format("{0} {1} {2}\n", Path, Value, Timestamp); | ||
| var line = string.Format("{0} {1} {2}\n", Path, Convert.ToString(Value).Replace(",","."), Timestamp); |
There was a problem hiding this comment.
Why do you think that target graphite server support dots?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graphite API supports int and double values as input.
The changes are necessary that this implementation does also support double values and are able to send them to Graphite.
Support for "," and "." as decimal delimiter is a little bit dirty....