Skip to content

clean up paper tasks to match paper rewards#6

Merged
johnzhang3 merged 7 commits intomainfrom
john/paper_task_cleanup
Apr 18, 2026
Merged

clean up paper tasks to match paper rewards#6
johnzhang3 merged 7 commits intomainfrom
john/paper_task_cleanup

Conversation

@johnzhang3
Copy link
Copy Markdown
Collaborator

@johnzhang3 johnzhang3 commented Apr 13, 2026

Summary

  • Simplifies the paper-task Spot push rewards/configs around goal distance, gripper proximity, and object velocity for box, chair, cone, rack, and tire push tasks.
  • Adds simplified Spot upright analysis tasks for box, chair, rack, cone, and tire, with shared orientation reward and reset helpers.
  • Fixes upright resets so random object orientations are rejection-sampled when they already satisfy the task success predicate before ground-clearance height is computed.
  • Updates task registration/import coverage, Spot task typing, generated MPC state capture, repo guidance, and the Pixi lockfile for the updated public Judo/MuJoCo dependency set.

Root Cause

The upright reset helper sampled from all unit quaternions. Some sampled poses already matched each upright task's success predicate, and run_mpc latches success for the full episode, so benchmark episodes could be counted as solved immediately after reset.

Validation

  • pixi run pytest tests/test_tasks.py -k simplified_spot_upright_reset -q
  • pixi run pytest tests/test_tasks.py -q
  • pixi run pytest tests/ -q
  • pixi run pre-commit run --all-files
  • pixi run pyright sumo/ (0 errors; existing MuJoCo stub warnings remain)

@johnzhang3 johnzhang3 marked this pull request as ready for review April 14, 2026 02:40
@johnzhang3 johnzhang3 requested a review from bhung-bdai April 14, 2026 16:56
@johnzhang3 johnzhang3 merged commit dc4aded into main Apr 18, 2026
2 checks passed
@johnzhang3 johnzhang3 deleted the john/paper_task_cleanup branch April 18, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants