Update organize_imagenet_webdataset.py#26
Open
tsagkas wants to merge 1 commit intorai-opensource:mainfrom
Open
Update organize_imagenet_webdataset.py#26tsagkas wants to merge 1 commit intorai-opensource:mainfrom
tsagkas wants to merge 1 commit intorai-opensource:mainfrom
Conversation
Previously, the function failed with an unhandled FileNotFoundError when a shard did not yet exist, causing the script to crash on first run. I added FileNotFoundError to the exception handling clause to allow the function to return False in this case, enabling shard creation to proceed as intended. This change ensures the script behaves correctly when starting from scratch and avoids unnecessary runtime errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the function failed with an unhandled FileNotFoundError when a shard did not yet exist, causing the script to crash on first run. I added FileNotFoundError to the exception handling clause to allow the function to return False in this case, enabling shard creation to proceed as intended.
This change ensures the script behaves correctly when starting from scratch and avoids unnecessary runtime errors.