Add hello demo to Portal home page#98
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA minimal home page change adds the hardcoded text "hello demo" to the public home hero section in PortalShell, with a corresponding e2e test assertion to verify the text is visible on the public home page. ChangesHome page text addition
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a small, explicit “hello demo” text snippet to the public (unauthenticated) Portal home page hero section and updates the existing Playwright helper to assert that the text is visible, aligning with Issue #97’s request for a minimal visible content change.
Changes:
- Render the exact text
hello demoin the public home page hero area. - Extend the
verifyPublicHomee2e helper to asserthello demois visible.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/app/(frontend)/_components/PortalShell.tsx |
Adds a new hero-area paragraph that renders hello demo on the public home page. |
tests/e2e/app.spec.ts |
Adds a Playwright visibility assertion for hello demo within the existing public-home verification helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
hello demoto the public Portal home page hero area.Verification
corepack pnpm test:e2eattempted; blocked because Docker is not installed in this runtime (spawnSync docker ENOENT).CI=true corepack pnpm test:e2eretried after native build approval; reached Playwright and hit the same missing Docker blocker.corepack pnpm lintattempted; blocked by existing Next lint invocation/config mismatch (Invalid project directory ... /lint).corepack pnpm exec eslint src/app/(frontend)/_components/PortalShell.tsx tests/e2e/app.spec.tsattempted; blocked by existing ESLint 9 migration/config mismatch.corepack pnpm exec tsc --noEmitattempted; blocked by existing missingreact-force-graph-2dmodule/type declaration.Closes #97
Summary by CodeRabbit