Skip to content

Treat TinyTDS failed dbsqlsend() errors as ConnectionNotEstablished #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidanharan merged 1 commit into from
Jul 29, 2026
+3 −1
Merged

Treat TinyTDS failed dbsqlsend() errors as ConnectionNotEstablished #1393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@

#### Fixed

- [#1393](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1393) Treat TinyTDS `failed dbsqlsend() function` errors as `ConnectionNotEstablished` so they're retried instead of surfaced as `StatementInvalid`.

Please check [8-1-stable](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/8-1-stable/CHANGELOG.md) for previous changes.
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ def type_map

def translate_exception(exception, message:, sql:, binds:)
case message
when /(SQL Server client is not connected)|(failed to execute statement)/i
when /(SQL Server client is not connected)|(failed to execute statement)|(failed dbsqlsend)/i
ConnectionNotEstablished.new(message, connection_pool: @pool)
when /(cannot insert duplicate key .* with unique index) | (violation of (unique|primary) key constraint)/i
RecordNotUnique.new(message, sql: sql, binds: binds, connection_pool: @pool)
Expand Down
Loading