Improve documentation of BasicObject inheritance and XmlBase#nil?#27
Open
eikes wants to merge 2 commits intorails:masterfrom
Open
Improve documentation of BasicObject inheritance and XmlBase#nil?#27eikes wants to merge 2 commits intorails:masterfrom
eikes wants to merge 2 commits intorails:masterfrom
Conversation
eikes
commented
Feb 24, 2026
Comment on lines
+127
to
+129
| # +nil?+ is an instance method not implemented on the +BasicObject+, | ||
| # but since +nil?+ won't ever be an XML tag, it is pretty safe to | ||
| # define it here. |
Author
There was a problem hiding this comment.
To be honest. We don't even need this nil? implementation anymore. method_missing does not require it anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.