feat: minimal set of changes to work in python3#6
Open
activescott wants to merge 1 commit intorainforestautomation:masterfrom
Open
feat: minimal set of changes to work in python3#6activescott wants to merge 1 commit intorainforestautomation:masterfrom
activescott wants to merge 1 commit intorainforestautomation:masterfrom
Conversation
|
@activescott Thanks for this PR, it's working beautifully for me so far on Raspberry Pi OS with Python3. I'm using it to provide the instantaneous usage to Home Assistant.
|
Author
|
Nice! @J-L thoughts on merging this one? |
Author
|
@J-L Anything I can do to help get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty minimal set of changes to make this library work on python3. I tested on macOS Monterey 12.1 and Python 3.9.10 with a Rainforest Automation EMU-2 (Z105-2-EMU2-LEDD_JM).
If you see something you'd prefer be done differently, please leave a comment here or on the code in question and I'm happy to work with you to get it merged. Thanks for providing this library and the reference documentation therein.