Skip to content

Add prod deployment tests for MetaBoard on all supported networks #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 1 commit into from
Mar 10, 2026
+36 −0
Merged

Add prod deployment tests for MetaBoard on all supported networks #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/rainix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ jobs:
env:
ETH_RPC_URL: ${{ secrets.CI_DEPLOY_SEPOLIA_RPC_URL || vars.CI_DEPLOY_SEPOLIA_RPC_URL }}
CI_FORK_ETH_RPC_URL: ${{ secrets.RPC_URL_ETHEREUM_FORK || vars.RPC_URL_ETHEREUM_FORK || '' }}
CI_FORK_ARB_RPC_URL: ${{ secrets.CI_FORK_ARB_RPC_URL || vars.CI_FORK_ARB_RPC_URL || '' }}
CI_FORK_BASE_RPC_URL: ${{ secrets.CI_FORK_BASE_RPC_URL || vars.CI_FORK_BASE_RPC_URL || '' }}
CI_FORK_BASE_SEPOLIA_RPC_URL: ${{ secrets.CI_FORK_BASE_SEPOLIA_RPC_URL || vars.CI_FORK_BASE_SEPOLIA_RPC_URL || '' }}
CI_FORK_FLARE_RPC_URL: ${{ secrets.CI_FORK_FLARE_RPC_URL || vars.CI_FORK_FLARE_RPC_URL || '' }}
CI_FORK_POLYGON_RPC_URL: ${{ secrets.CI_FORK_POLYGON_RPC_URL || vars.CI_FORK_POLYGON_RPC_URL || '' }}
ETHERSCAN_API_KEY: ${{ secrets.EXPLORER_VERIFICATION_KEY }}
run: nix develop -c ${{ matrix.task }}

Expand Down
31 changes: 31 additions & 0 deletions test/lib/deploy/LibMetaBoardDeploy.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,35 @@ contract LibMetaBoardDeployTest is Test {

assertEq(address(metaBoard).codehash, LibMetaBoardDeploy.METABOARD_DEPLOYED_CODEHASH);
}

function checkProdDeployment(string memory envVar) internal {
vm.createSelectFork(vm.envString(envVar));
address deployed = LibMetaBoardDeploy.METABOARD_DEPLOYED_ADDRESS;
Comment on lines +28 to +30
Copy link

@coderabbitai coderabbitai bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fail fast on an unset RPC URL before calling createSelectFork.

Line 29 forks whatever comes back from vm.envString(envVar). In CI these vars are wired with '' fallbacks, so a missing secret turns into createSelectFork("") and surfaces as a low-signal fork error instead of naming the misconfigured env key.

Proposed fix 
     function checkProdDeployment(string memory envVar) internal {
-        vm.createSelectFork(vm.envString(envVar));
+        string memory rpcUrl = vm.envString(envVar);
+        require(bytes(rpcUrl).length > 0, string.concat("Missing RPC URL: ", envVar));
+        vm.createSelectFork(rpcUrl);
         address deployed = LibMetaBoardDeploy.METABOARD_DEPLOYED_ADDRESS;
         assertTrue(deployed.code.length > 0, string.concat("MetaBoard not deployed: ", envVar));
         assertEq(
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
function checkProdDeployment(string memory envVar) internal {
vm.createSelectFork(vm.envString(envVar));
address deployed = LibMetaBoardDeploy.METABOARD_DEPLOYED_ADDRESS;
function checkProdDeployment(string memory envVar) internal {
string memory rpcUrl = vm.envString(envVar);
require(bytes(rpcUrl).length > 0, string.concat("Missing RPC URL: ", envVar));
vm.createSelectFork(rpcUrl);
address deployed = LibMetaBoardDeploy.METABOARD_DEPLOYED_ADDRESS;
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@test/lib/deploy/LibMetaBoardDeploy.t.sol` around lines 28 - 30,
checkProdDeployment currently calls vm.createSelectFork(vm.envString(envVar))
directly which will pass an empty string in CI and produce a low-signal fork
error; first read the env via vm.envString(envVar) into a local, assert it is
non-empty (e.g. require(bytes(rpcUrl).length > 0, "missing RPC env: " + envVar)
or revert with a clear message) and only then call vm.createSelectFork(rpcUrl);
reference the function checkProdDeployment and the calls to vm.envString and
vm.createSelectFork to locate where to add the pre-check.

assertTrue(deployed.code.length > 0, string.concat("MetaBoard not deployed: ", envVar));
assertEq(
deployed.codehash,
LibMetaBoardDeploy.METABOARD_DEPLOYED_CODEHASH,
string.concat("MetaBoard codehash mismatch: ", envVar)
);
}

function testProdDeployArbitrum() external {
checkProdDeployment("CI_FORK_ARB_RPC_URL");
}

function testProdDeployBase() external {
checkProdDeployment("CI_FORK_BASE_RPC_URL");
}

function testProdDeployBaseSepolia() external {
checkProdDeployment("CI_FORK_BASE_SEPOLIA_RPC_URL");
}

function testProdDeployFlare() external {
checkProdDeployment("CI_FORK_FLARE_RPC_URL");
}

function testProdDeployPolygon() external {
checkProdDeployment("CI_FORK_POLYGON_RPC_URL");
}
}