Fix file path regex pattern in stack trace response#110
Fix file path regex pattern in stack trace response#110dbywalec wants to merge 1 commit intoraix:masterfrom
Conversation
The original regex pattern would encounter for characters other than white space (\S) as part of the file path. In some cases this is not true. Apparently a space is a valid file path character and must be encountered for. This bug would prevent the VSCode from stopping on break points, whereas the actual Perl debugger would indicate a break point was hit.
|
Thanks @dbywalec for creating the pr :) - it seems to be triggering issues in the travis tests - I'm thinking we have to move more complex regex's to the |
|
Thanks for feedback. I thought it would have been a low hanging fruit. I did not anticipate changing such as an isolated line of code would break any other tests. Perhaps a simpler regular expression for file path would do: I will be glad to test on a live example as soon as you have come up with some better solution. |
The original regex pattern would encounter for characters other than white space (\S)
as part of the file path. In some cases this is not true.
Apparently a space is a valid file path character and must be encountered for.
This bug would prevent the VSCode from stopping on break points, whereas
the actual Perl debugger would indicate a break point was hit.
Fixes #104