feat: implement string interning for file_path and module_path#30
Open
ram-nadella wants to merge 1 commit intomainfrom
Open
feat: implement string interning for file_path and module_path#30ram-nadella wants to merge 1 commit intomainfrom
ram-nadella wants to merge 1 commit intomainfrom
Conversation
- Changed Symbol struct to use Arc<str> for file_path and module_path - Created StringCache module for thread-safe string deduplication - Integrated string interning into SymbolIndex at symbol insertion time - Updated all parsers to use String instead of PathBuf for file paths - Fixed all tests to work with the new types This optimization significantly reduces memory usage for large codebases by ensuring each unique file path and module path is stored only once in memory, with symbols holding lightweight Arc<str> references. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Arc<str>instead ofPathBuf/Stringfor interned fieldsStringCachemodule for managing interned stringsMotivation
In large codebases with thousands of files and tens of thousands of symbols, the same file paths and module paths are duplicated across many symbols. This PR optimizes memory usage by ensuring each unique path string is stored only once in memory.
Changes
Symbol struct changes:
file_path:PathBuf→Arc<str>(interned)module_path:String→Arc<str>(interned)Arc<str>String interning implementation:
StringCachemodule with thread-safe string deduplicationparking_lot::RwLockandHashMap<String, Arc<str>>SymbolIndexto automatically intern strings when symbols are addedParser updates:
Stringinstead ofPathBuffor file pathsTest updates:
Performance Impact
Test plan
🤖 Generated with Claude Code