Added Tags for activities, and Rich Text Editor.#316
Added Tags for activities, and Rich Text Editor.#316sorryIMessedup wants to merge 5 commits intoramack:masterfrom
Conversation
|
Thanks for your contribution. The Tag stuff seems to miss the storage. For the Rich Text it might be incomplete, but please separate those different features in separate PRs! |
| } else { | ||
| if (currentActivity == null) { | ||
| ActivityHelper.helper.insertActivity(new DiaryActivity(-1, mActivityName.getText().toString(), mActivityColor)); | ||
| ActivityHelper.helper.insertActivity(new DiaryActivity(-1, mActivityName.getText().toString(), mActivityColor,mActivityTag.getText().toString())); |
There was a problem hiding this comment.
would be cool to have a space after the comma in parameter lists, but yea that's quite minor :-)
| /** | ||
| * must call init at your application level or equiv, before you use any other methods | ||
| */ | ||
| public class SPUtils { |
There was a problem hiding this comment.
Why do we need to have this SPUtils class? Can you elaborate on that and explain its function in the comment, not only the need for initialization?
| public void onBindViewHolder(SelectViewHolders holder, int position) { | ||
| DiaryActivity act = mActivityList.get(position); | ||
| NumberFormat formatter = new DecimalFormat("#0.00"); | ||
| holder.mTag.setText("Tag:"+ SPUtils.getString(act.getName()+act.getColor())); |
There was a problem hiding this comment.
don't we need localization here, (and a space after the colon, as this is user visible)?
| super(itemView); | ||
| itemView.setOnClickListener(this); | ||
| itemView.setOnLongClickListener(this); | ||
| mTag= (TextView) itemView.findViewById(R.id.tv_tag); |
There was a problem hiding this comment.
what is the meaning of the abbreviation "tv"?
There was a problem hiding this comment.
I think we don't need this change to be merged, right? can you remove it from the PR?
| @Override | ||
| public void onClick(View view) { | ||
| Intent intent = new Intent(RedPacketActivity.this, MainActivity.class); | ||
| // 启动目标Activity |
There was a problem hiding this comment.
is that Chinese? maybe you can remove it?
| import de.rampro.activitydiary.ui.generic.BaseActivity; | ||
|
|
||
|
|
||
| public class RedPacketActivity extends BaseActivity implements |
There was a problem hiding this comment.
Can you add a comment explaining what this class is about?
| protected void onResume() { | ||
| super.onResume(); | ||
| try { | ||
| String path = "https://poss-videocloud.cns.com.cn/oss/2021/05/08/chinanews/MEIZI_YUNSHI/onair/25AFA3CA2F394DB38420CC0A44483E82.mp4" ; |
There was a problem hiding this comment.
I think this is not adequate styling...
There was a problem hiding this comment.
this seems to be included by fault, please remove it.
3 participants
Added Tags for activities, and Rich Text Editor.