Document wallet GitHub link API response

[TUPM96]

/claim #229

Summary

• Documented POST /api/v1/wallets/link-github in docs/api-examples.md.
• Clarified that the GitHub login comes from the signed session cookie while the body carries only address, nonce, and signature_hex.
• Added the successful response shape, matching the public wallet object returned by wallet_to_dict() after github_login is linked.
• Added regression coverage in tests/test_docs_public_urls.py.

Evidence

• Request fields match app/main.py::api_link_wallet_github().
• Signature guidance matches app/ledger/service.py::wallet_link_payload() and link_wallet_to_github().
• Response fields match app/main.py::wallet_to_dict().

Verification

• uv run --python 3.12 --extra dev python -m pytest tests/test_docs_public_urls.py -q -> 14 passed
• uv run --python 3.12 --extra dev python scripts/docs_smoke.py -> docs smoke ok
• uv run --python 3.12 --extra dev ruff check docs/api-examples.md tests/test_docs_public_urls.py -> all checks passed
• uv run --python 3.12 --extra dev ruff format --check --preview docs/api-examples.md tests/test_docs_public_urls.py -> 2 files already formatted
• uv run --python 3.12 --extra dev python -m pytest -q -> 206 passed, 2 warnings
• git diff --check -> clean

No private keys, wallet secrets, real signatures, payout details, PayPal details, deployment credentials, private vulnerability details, or MRWK price claims are included.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds documentation and a regression test for linking a registered wallet to the authenticated GitHub account via a new API example in the docs.

Changes:

• Document POST /api/v1/wallets/link-github request/response in docs/api-examples.md
• Add a docs regression test to ensure key strings for the new example remain present

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tests/test_docs_public_urls.py	Adds assertions validating the new “link GitHub” API example is present in docs
docs/api-examples.md	Adds a curl example and sample JSON response for linking a wallet to a GitHub login

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[MolhamHamwi]

No blockers from my review.

Evidence checked:

• Inspected docs/api-examples.md and confirmed the new /api/v1/wallets/link-github example states that GitHub login comes from the signed-in session cookie, not request body.
• Cross-checked app/main.py::api_link_wallet_github(): it passes github_login from require_github_login, reads only address, nonce, and signature_hex from JSON, and returns wallet_to_dict().
• Cross-checked app/ledger/service.py::wallet_link_payload(): the documented compact sorted-key payload fields match type, normalized address, normalized github_login, and nonce.
• Inspected tests/test_docs_public_urls.py coverage for endpoint path, session-cookie wording, signature placeholder, payload type, GitHub login placeholder, and response nonce fields.
• Ran pytest tests/test_docs_public_urls.py -q locally: 14 passed.
• Ran ruff check docs/api-examples.md tests/test_docs_public_urls.py and ruff format --check tests/test_docs_public_urls.py locally: both passed.

The docs change is focused and I did not see wallet private-key, deployment, payout-detail, MRWK price-claim, or secret-handling exposure in the touched scope.