Link bounty award proofs on detail pages#261
Closed
Yassinbrine wants to merge 1 commit into
Closed
Conversation
weilixiong
approved these changes
May 25, 2026
weilixiong
left a comment
There was a problem hiding this comment.
Review ✅ APPROVED
LOW — verified diff clean, no unrelated files. MW #219 round 7.
weilixiong
approved these changes
May 25, 2026
weilixiong
left a comment
There was a problem hiding this comment.
Review ✅ APPROVED — LOW risk, clean diff, MW #219 round 7.
|
No blockers from my review. Evidence checked:
The route still returns 404 for missing bounties and now avoids calling the API helper from inside the HTML route. |
MolhamHamwi
reviewed
May 25, 2026
Contributor
MolhamHamwi
left a comment
There was a problem hiding this comment.
No blockers from my review.
Evidence checked:
- Inspected
app/main.py::bounty_awards_to_dict()andbounty_page()and confirmed it only joins proof-backedbounty_paymentledger entries for the currentProof.bounty_id, keeps newest-first sequence ordering, skips duplicate ledger sequences, and reuses_activity_row()so proof/submission/account/ledger links match the public activity shape. - Inspected
app/templates/bounty_detail.htmland confirmed public proof, account, submission, and ledger links are rendered withsafe_public_url()guarding external submission URLs and a clear empty state when there are no paid awards. - Inspected
tests/test_bounty_pages.py::test_bounty_detail_links_paid_award_proofsfor coverage of the paid-award section, proof hash link, account link, sanitized submission link, and ledger link. - Hosted check
Quality, readiness, docs, and image checksis green. - Ran
./.venv/bin/python -m pytest tests/test_bounty_pages.py -q-> 5 passed. - Ran
./.venv/bin/python -m ruff check app/main.py tests/test_bounty_pages.py-> passed. - Ran
./.venv/bin/python -m ruff format --check app/main.py tests/test_bounty_pages.py-> 2 files already formatted. - Ran
git diff --check origin/main...HEAD-> clean.
No secrets, wallet/private-key material, payout credentials, private deployment values, private vulnerability details, or MRWK price claims were reviewed or disclosed.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounty #164
Verification
.\.venv\Scripts\python.exe -m pytest tests\test_bounty_pages.py -q-> 5 passed..\.venv\Scripts\python.exe -m ruff check app\main.py tests\test_bounty_pages.py-> passed..\.venv\Scripts\python.exe -m ruff format --check app\main.py tests\test_bounty_pages.py-> passed.