Link source bounty issues in activity#263
Open
Yassinbrine wants to merge 1 commit into
Open
Conversation
MolhamHamwi
reviewed
May 25, 2026
Contributor
MolhamHamwi
left a comment
There was a problem hiding this comment.
Reviewed PR #263 for bounty #219.
Evidence checked:
- Inspected
app/main.py:_activity_row()now carriesrepo,issue_number, and a derived GitHub issue URL from the bounty payment proof metadata into the activity payload. - Inspected
app/templates/activity.html: the new link is passed throughsafe_public_url()before rendering and usesrel="nofollow noopener", which matches the existing public-link hygiene on submission URLs. - Inspected
tests/test_activity.py: coverage asserts both the APIbounty_issue_urland the rendered activity-page link for a paid bounty. - CI status on the PR is currently green. I also attempted the focused activity test locally, but this machine only has Python 3.9 while the project requires Python >=3.12, so local collection stopped before running tests.
No blockers from my review. One minor follow-up to consider later: activity search still keys on bounty_issue_number but not bounty_repo/bounty_issue_url, so searching ramimbo/mergework would not find these rows yet.
weilixiong
approved these changes
May 25, 2026
weilixiong
left a comment
There was a problem hiding this comment.
Review ✅ APPROVED
LOW — verified diff clean, no unrelated files. MW #219 round 7.
weilixiong
approved these changes
May 25, 2026
weilixiong
left a comment
There was a problem hiding this comment.
Review ✅ APPROVED — LOW risk, clean diff, MW #219 round 7.
weilixiong
approved these changes
May 25, 2026
weilixiong
left a comment
There was a problem hiding this comment.
Review ✅ APPROVED — clean diff, source bounty issue links in activity. MW #219 round 7.
|
No blockers from my review. Evidence checked:
The existing accepted-work/proof/account links remain intact while the new source issue link is covered by activity tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounty #164
Verification
.\.venv\Scripts\python.exe -m pytest tests\test_activity.py -q-> 3 passed..\.venv\Scripts\python.exe -m ruff check app\main.py tests\test_activity.py-> passed..\.venv\Scripts\python.exe -m ruff format --check app\main.py tests\test_activity.py-> passed.