Integrate ps2xStudio and improve elf_analyzer callback detection#83
Merged
ran-j merged 10 commits intoran-j:mainfrom Mar 1, 2026
Merged
Conversation
Contributor
BlackLineInteractive
commented
Feb 24, 2026
BlackLineInteractive
commented
Updated dependencies and improved comments for clarity.
ran-j
requested changes
Feb 25, 2026
ps2xStudio/CMakeLists.txt
Outdated
Comment on lines
43
to
44
| find_package(SDL2 REQUIRED) | ||
| find_package(OpenGL REQUIRED) |
Owner
There was a problem hiding this comment.
Use fetch to install this dependency
ran-j
requested changes
Feb 27, 2026
|
|
||
| target_include_directories(ps2x_tests PRIVATE | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/include | ||
| ${CMAKE_SOURCE_DIR}/ps2xRecomp/include |
Contributor
Author
There was a problem hiding this comment.
Probably by accident, sorry 😬
Owner
|
Can you write a small documentation for this # on wiki ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.