Open
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
richard-cox
reviewed
Apr 7, 2026
Member
richard-cox
left a comment
richard-cox
left a comment
There was a problem hiding this comment.
Would you be able to update package.json as well? if we're building with 24 we should dev with 24 as well.
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Member
Author
|
@richard-cox sure thing, this has been updated in 49a3861. This is ready for another review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This targets Node 24 in CI
Fixes #16758
Occurred changes and/or fixed issues
Technical notes summary
I left the node version as-is in
package.json. I don't think there's any requirement to add further restrictions for this project, but we should ensure that this builds on active LTS versions of node.Areas or cases that should be tested
Relates work