Skip to content

Form Array Demo#45

Open
tyllrb wants to merge 3 commits intomasterfrom
form-arrays
Open

Form Array Demo#45
tyllrb wants to merge 3 commits intomasterfrom
form-arrays

Conversation

@tyllrb
Copy link
Copy Markdown
Contributor

@tyllrb tyllrb commented Feb 6, 2017

FormArray Demo for Augury guides. Though Augury doesn't have any major features pertinent to forms that can dynamically add/remove fields. Though, good to have for future feature development.

@rajinder-yadav
Copy link
Copy Markdown
Contributor

LGTM :shipit:

@santiago-elustondo
Copy link
Copy Markdown
Contributor

This PR doesn't compile due to line 29 of model-form.component.ts

this.fg.addControl('message');

the above does not conform to the method signature.

addControl(name: string, control: AbstractControl) : void

However, this method is not even used anywhere...
This PR seems like a bit of a hackjob.

@yallen011 yallen011 added stale issue is not currently being worked on or hasn't been updated in over 30 days and removed in progress labels Nov 26, 2019
@sumitarora sumitarora force-pushed the master branch 2 times, most recently from 39e6968 to cf9766b Compare February 18, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale issue is not currently being worked on or hasn't been updated in over 30 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants