Skip to content

relaxed memory order #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-s-steiner merged 1 commit into from
Mar 10, 2026
Merged

relaxed memory order #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/ParallelPriotityQueue/SpapQueue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ inline bool SpapQueue<T, netw, WorkerTemplate, LocalQType>::pushDuringProcessing
std::size_t prevCount = globalCount_.load(std::memory_order_relaxed);
while (prevCount > 0U
&& (not globalCount_.compare_exchange_weak(
prevCount, prevCount + 1U, std::memory_order_acquire, std::memory_order_relaxed))) { };
prevCount, prevCount + 1U, std::memory_order_relaxed, std::memory_order_relaxed))) { };

// Only inserts if queue is still running
if (prevCount > 0U) {
Expand All @@ -428,7 +428,7 @@ inline bool SpapQueue<T, netw, WorkerTemplate, LocalQType>::pushDuringProcessing
success = std::get<worker>(workerResources_)->push(val, port);
}

if (not success) { globalCount_.fetch_sub(1U, std::memory_order_release); }
if (not success) { globalCount_.fetch_sub(1U, std::memory_order_relaxed); }
}

return success;
Expand Down