Skip to content

ci: add changesets release workflow #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphaelsalaja merged 1 commit into from
Apr 26, 2026
Merged

ci: add changesets release workflow #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Release

on:
push:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

jobs:
release:
name: Version or publish
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
id-token: write

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

- uses: pnpm/action-setup@v4

- uses: actions/setup-node@v4
with:
node-version: 20
cache: pnpm
registry-url: https://registry.npmjs.org

- run: pnpm install --frozen-lockfile

- run: pnpm build

Comment on lines +35 to +36
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm build runs turbo run build across the whole monorepo. In this repo, apps/marketing has a prebuild that regenerates tracked files under apps/marketing/src/generated/*, so running build here can dirty the workspace and accidentally include unrelated generated diffs in the Changesets version PR/publish commit. Consider removing this step, or scoping the build to the publishable package(s) (e.g., only @web-kits/audio) and/or running build only when actually publishing.

Suggested change
- run: pnpm build

Copilot uses AI. Check for mistakes.
- name: Create Release PR or publish
uses: changesets/action@v1
with:
version: pnpm changeset version
publish: pnpm changeset publish
commit: "chore(release): version packages"
title: "chore(release): version packages"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow configures actions/setup-node with registry-url, which typically relies on NODE_AUTH_TOKEN for npm auth. This job only exports NPM_TOKEN (and there is no .npmrc in-repo referencing NPM_TOKEN), so pnpm changeset publish may run without credentials. Consider also setting NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} (or adding an .npmrc that uses NPM_TOKEN) so publishing is reliably authenticated.

Suggested change
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Copilot uses AI. Check for mistakes.
NPM_CONFIG_PROVENANCE: "true"
Loading