Fix app shell keyboard accessibility#1676
Closed
simple-agent-manager[bot] wants to merge 1 commit into
Closed
Conversation
|
Contributor
Contributor
Author
|
Closing as superseded by the delegated accessibility remediation PR #1674, which has stronger scoped tests and should be the canonical PR for this finding. No code from this duplicate PR should be merged separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



status: ready-for-review
local_checks:
review_evidence:
Summary
#main-contenttargets without changing rendered page content or routing:focus-visiblefallback ring for keyboard usersValidation
pnpm --filter @simple-agent-manager/web test -- AppShell.test.tsxpnpm --filter @simple-agent-manager/web lint(passes with pre-existing warnings)pnpm --filter @simple-agent-manager/web typecheckpnpm --filter @simple-agent-manager/web buildNotes
This PR is intentionally narrow and non-breaking. It does not address broader UI review items like route-level code splitting or TanStack Query migration.