FIX: correct off-by-one in Higuchi FD inner loop#47
Merged
raphaelvallat merged 1 commit intomasterfrom Mar 6, 2026
Merged
Conversation
The inner loop summed j = 1 … N_m-1 (n_max-1 terms) instead of the correct j = 1 … N_m (n_max terms), dropping the last difference in each sub-series and slightly underestimating curve length. Fix: range(1, n_max) → range(1, n_max + 1) Also corrects the docstring formula (upper limit N_m-1 → N_m) and updates all higuchi_fd docstring examples and the unit test expected value to match the corrected output. Verified against the NeuroKit2 reference implementation which uses np.diff over all n_max differences. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 312 312
Branches 52 52
=========================================
Hits 312 312 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inner loop summed
j = 1 … N_m-1(n_max-1 terms) instead of the correctj = 1 … N_m(n_max terms), dropping the last difference in each sub-series and slightly underestimating curve length.Fix:
range(1, n_max)→range(1, n_max + 1)Also corrects the docstring formula (upper limit
N_m-1→N_m) and updates all higuchi_fd docstring examples and the unit test expected value to match the corrected output.