Update KerberosTicketTrace to use enum modes#21637
Open
eve0805 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! As part of our landing process, we manually verify that all modules work as expected. We've added the |
4 tasks
Contributor
Author
Live lab validation against Windows Server 2016 AD CS DC (192.168.189.160)Test commandsoff:metadata:ticket:full: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the Kerberos ticket trace configuration introduced in #21466 and revises the follow-up work from #21568 based on review feedback.
Instead of using
KerberosTicketTraceas a boolean plus a separateKerberosTicketTraceLeveloption, this PR changesKerberosTicketTraceitself into an enum.Relationship to Previous PRs
KerberosTicketTraceLevelas a follow-up verbosity option.KerberosTicketTrace.Changes
KerberosTicketTracefrom a boolean to an enum.KerberosTicketTracemodes:off: disables Kerberos ticket trace output.metadata: prints Kerberos request/response details while redacting binary field contents.ticket: prints full ticket/credential contents only, omitting AS-REQ, AS-REP, TGS-REQ, and TGS-REP message details.full: prints full Kerberos request/response details and full ticket/credential contents.KerberosTicketTraceLevel.Testing
bundle exec rspec spec/lib/msf/core/exploit/remote/kerberos/client_spec.rbbundle exec rspec spec/lib/rex/proto/kerberos/kerberos_logger_subscriber_spec.rbbundle exec rspec spec/lib/msf/base/serializer/readable_text_spec.rbbundle exec rubocop lib/msf/core/exploit/remote/kerberos/client.rb lib/msf/core/exploit/remote/kerberos/service_authenticator/options.rb lib/rex/proto/kerberos/kerberos_logger_subscriber.rb spec/lib/rex/proto/kerberos/kerberos_logger_subscriber_spec.rb