Defer statistics update until first access to improve performance#21643
Open
dwelch-r7 wants to merge 1 commit into
Open
Defer statistics update until first access to improve performance#21643dwelch-r7 wants to merge 1 commit into
dwelch-r7 wants to merge 1 commit into
Conversation
adfoster-r7
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Defer stats calculation until we need it, this results in running msfconsole with the
-qflag spinning up a 0.3-0.5s faster, I haven't removed the stats from the banner but I think we should consider it since it's really not that useful and it's adding time to the boot up process.Verification Steps
msfconsolenormally (without-q) — banner should display correct module counts as beforemsfconsole -q -x 'exit'— should boot and exit without errorbannercommand — module counts should display correctlybundle exec rspec spec/lib/msf/base/simple/statistics_spec.rb— all 11 examples passTest Evidence
with
-qwithout
-qEnvironment
AI Usage Disclosure
Kiro
Pre-Submission Checklist