Add feature flag to skip checksum validation for faster development boot#21645
Open
dwelch-r7 wants to merge 1 commit into
Open
Add feature flag to skip checksum validation for faster development boot#21645dwelch-r7 wants to merge 1 commit into
dwelch-r7 wants to merge 1 commit into
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
skip_checksum_validationfeature flag that skips module file checksum validation during boot.On every startup, msfconsole stat's all files under
modules/and computes CRC32 checksums to detect whether any module files have changed since the last boot. If files changed, it forces a full (non-deferred) module reload. This costs ~250ms per boot even when no files have changed, purely from the filesystem traversal and checksum comparison.For developers who iterate frequently on the framework itself (not module files), this check is unnecessary overhead — they can run
reload_allwhen they've actually modified modules. This flag lets them skip it.Related to: #21639
Verification Steps
msfconsolenormally — boot behavior is unchanged (flag is off by default)featuresin msfconsole — confirmskip_checksum_validationappears in the list, disabledfeatures set skip_checksum_validation truesave, then restart msfconsole — confirm it boots fastertouch modules/exploits/multi/handler.rb), restart — confirm the change is NOT auto-detected (deferred load still used)reload_all— confirm modules reload correctlybundle exec rspec spec/lib/msf/ui/console/driver_skip_checksum_spec.rb— 3 examples passbundle exec rspec spec/lib/msf/core/feature_manager_spec.rb— all existing tests passTest Evidence
Before:
After:
Environment
AI Usage Disclosure
Kiro
Pre-Submission Checklist