Suppress Pry history loading only if Pry is already defined#21648
Open
dwelch-r7 wants to merge 1 commit into
Open
Suppress Pry history loading only if Pry is already defined#21648dwelch-r7 wants to merge 1 commit into
dwelch-r7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's your PR description:
Description
Defer Pry loading in
Rex::Ui::Text::Shell#runto avoid paying therequire 'pry'cost on every msfconsole boot. Saves about 0.2s on my machine.The
runmethod previously did an unconditionalrequire 'pry'solely to setPry.config.history_load = false— a config that prevents Pry from loading its own history whenbinding.pryis used. This loaded the entire Pry gem at boot even though most sessions never use Pry.The change replaces
require 'pry'withif defined?(Pry), which only sets the config when Pry has already been loaded elsewhere.Verification Steps
msfconsolenormally — verify it boots without errorsprycommand inside msfconsole — verify Pry session starts and Pry history isn't polluted with framework commandsTest Evidence
Environment
AI Usage Disclosure
Kiro
Pre-Submission Checklist