Fix/align deps and central portal publish#10
Merged
Conversation
…cessNodes postProcessNodes made a single pass over the incompletes list. Initializing an INITIALIZABLE node fires providersChanged() on its clients, which can flip an already-visited PARTIALLY_INITIALIZED node (whose last blocking optional provider was just initialized) to INITIALIZABLE. The iterator had already passed it, so it was stranded and the run failed with "Incomplete nodes left", depending on the order incompletes were visited -- which is why it only surfaced on larger schemas. Wrap the existing pass in a do/while that repeats until a full pass removes nothing. Terminates (size is bounded below; each looping pass removes >= 1). Adds a deterministic regression test (a web of required+optional cycles, the shape that turns up modelling a complex database schema) that strands t8 on the old single-pass code and resolves completely with the fix.
OSSRH (oss.sonatype.org) shut down 2025-06-30, breaking the release deploy, and the publish config had drifted from rapiddweller-benerator-ce. Mirror the fixes already landed on benerator development: - Replace nexus-staging-maven-plugin with central-publishing-maven-plugin 0.11.0 (autoPublish), drop the dead oss.sonatype.org snapshot distributionManagement (the plugin defaults to the Portal snapshots repo), and repoint the snapshot resolution repo to the Portal snapshots URL. - Rename settings.xml server id ossrh -> central for the Portal user token (the OSSRH_USERTOKEN* secrets must now hold a Central Portal token). - Pin maven-gpg-plugin to 3.1.0; 3.2.x ignores the settings.xml passphrase and breaks batch signing. Also makes the build reproducible. - Replace the silent gpg --import with a step that fails fast and explains the cause when GPG_PRIVATE_KEY_ENCODED is empty or carries no secret key. - Bump deprecated GitHub Actions off Node 20: checkout/cache v2->v5, upload-artifact v2->v6, download-artifact v2->v7. Align shared dependency versions with benerator: slf4j 1.7.32 -> 1.7.36, log4j 2.17.0 -> 2.25.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.