Fix cuda error when sorting empty pl.concat result#21825
Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom Apr 6, 2026
Merged
Fix cuda error when sorting empty pl.concat result#21825rapids-bot[bot] merged 2 commits intorapidsai:mainfrom
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom
Conversation
Contributor
|
/ok to test 8737854 |
Contributor
Author
|
Looks like #21867 moved the tests into |
Contributor
|
Sorry for the delay @jberg5 On main, I believe we see the correct behavior now In [1]: import polars as pl
In [2]: df = pl.LazyFrame({"a": [1, 2, 3]})
In [3]: q = pl.concat([df.filter(pl.col("a") == 0), df.filter(pl.col("a") == 4)]).sort("a").collect(engine="gpu")
In [4]: q
Out[4]:
shape: (0, 1)
┌─────┐
│ a │
│ --- │
│ i64 │
╞═════╡
└─────┘So a unit test would still be appreciated (in |
Contributor
Author
|
Thanks @mroeschke , just have the test case now. |
Contributor
|
/ok to test e032a1b |
mroeschke
approved these changes
Apr 6, 2026
Contributor
|
/merge |
Contributor
|
Thanks again @jberg5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should close #21824
See test case for repro, but basically if you had
then
q.collect(engine="gpu")you'd get a cuda exception because we'd try to do an out of bounds access on an empty table.edit: turns out #21690 fixed this issue. This PR now will only contribute a test case.
Checklist