Skip to content

Fix lists::segmented_gather to return empty for empty input#22115

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
davidwendt:seg-mented-fault
Apr 15, 2026
Merged

Fix lists::segmented_gather to return empty for empty input#22115
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
davidwendt:seg-mented-fault

Conversation

@davidwendt
Copy link
Copy Markdown
Contributor

@davidwendt davidwendt commented Apr 13, 2026

Description

Adds a check to the list column segmented gather function to handle empty input by returning an empty result.
Also adds a gtest for this condition.

Closes #22112

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Apr 13, 2026
@davidwendt davidwendt requested a review from a team as a code owner April 13, 2026 12:19
@davidwendt davidwendt requested review from mythrocks and shrshi April 13, 2026 12:19
@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Apr 13, 2026
Copy link
Copy Markdown
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidwendt
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit eb41ee6 into rapidsai:main Apr 15, 2026
123 of 125 checks passed
@davidwendt davidwendt deleted the seg-mented-fault branch April 15, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

segmented_gather crashes on LIST column with 0-size offsets

4 participants