Disable csv tests temporarily & fix dask_cudf failure#22203
Merged
mroeschke merged 5 commits intorapidsai:pandas3from Apr 20, 2026
Merged
Disable csv tests temporarily & fix dask_cudf failure#22203mroeschke merged 5 commits intorapidsai:pandas3from
mroeschke merged 5 commits intorapidsai:pandas3from
Conversation
galipremsagar
added
3 - Ready for Review
galipremsagar
requested review from
TomAugspurger
and removed request for
a team
galipremsagar
added
the
improvement
mroeschke
reviewed
Apr 17, 2026
mroeschke
reviewed
Apr 17, 2026
mroeschke
approved these changes
Apr 20, 2026
galipremsagar
changed the title
Contributor
Author
|
@mroeschke All jobs except pandas-test pass 🥳 . Could you give another review for new fix I pushed after your approval. |
mroeschke
approved these changes
Apr 20, 2026
| and "_local_time" in o.__dict__ | ||
| for o in objs_with_len | ||
| ): | ||
| result._local_time = concat_columns( |
Contributor
There was a problem hiding this comment.
My hope is that if we can transition to relying on _utc_time in the future we can remove all of this. I suspect this is a symptom of a bug somewhere in DatetimeTZColumn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
date_format#22094dask_cudftest_tz_localizeregression introduced by Fixdatetime&timedeltafailures in pandas test suite #22174. Afterthat PR,
DatetimeTZColumn.to_pandas()relies on a cached_local_timetoproduce correct values near DST transitions (the stored UTC column is
inaccurate because
tz_localizesearchsorts a non-monotonic transitiontable). The cache was being dropped during
concat_columnsand again duringthe
ColumnBase.createrewrap inSeries._concat, so concatenated daskpartitions fell back to the incorrect UTC path. This PR preserves
_local_timethrough both steps when all inputs areDatetimeTZColumnswith the cache present.
Checklist