Skip to content

Fix nightly build matrix#2054

Open
KyleFromNVIDIA wants to merge 1 commit intorapidsai:mainfrom
KyleFromNVIDIA:fix-nightly-build-matrix
Open

Fix nightly build matrix#2054
KyleFromNVIDIA wants to merge 1 commit intorapidsai:mainfrom
KyleFromNVIDIA:fix-nightly-build-matrix

Conversation

@KyleFromNVIDIA
Copy link
Copy Markdown
Member

java-build and go-build should depend on their corresponding -matrix workflows, but this was not done in build.yaml. Fix this.

`java-build` and `go-build` should depend on their corresponding
`-matrix` workflows, but this was not done in `build.yaml`. Fix this.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner May 4, 2026 13:09
@KyleFromNVIDIA KyleFromNVIDIA requested a review from msarahan May 4, 2026 13:09
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Introduces a non-breaking change ci labels May 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 451af914-abc6-4434-86bc-3474715ba928

📥 Commits

Reviewing files that changed from the base of the PR and between 7cf69cb and 25a93fe.

📒 Files selected for processing (1)
  • .github/workflows/build.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD pipeline job dependencies to improve workflow execution efficiency.

Walkthrough

GitHub Actions workflow job dependencies are corrected so that go-build and java-build jobs depend on their respective matrix-computation jobs (go-build-matrix and java-build-matrix) rather than cpp-build.

Changes

Workflow Job Dependencies

Layer / File(s) Summary
Job Dependency Updates
.github/workflows/build.yaml
go-build job needs: field changed from cpp-build to go-build-matrix; java-build job needs: field changed from cpp-build to java-build-matrix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix nightly build matrix' directly describes the main change, which is fixing job dependencies for the build matrix in the GitHub Actions workflow.
Description check ✅ Passed The description clearly explains that java-build and go-build should depend on their corresponding -matrix workflows and identifies the specific file (build.yaml) where this fix was applied.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci non-breaking Introduces a non-breaking change

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants