Open
Conversation
madsbk
added
breaking
madsbk
force-pushed
the
redesign-statistics
branch
from
ff22c6a to
dc5895c
Compare
madsbk
force-pushed
the
redesign-statistics
branch
from
dc5895c to
9541e64
Compare
vyasr
approved these changes
Apr 17, 2026
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
One tiny question, otherwise LGTM.
Comment on lines
+233
to
+235
| if (!has_report_entry(name)) { | ||
| add_report_entry(name, {name}, Formatter::Bytes); | ||
| } |
Contributor
There was a problem hiding this comment.
Are you ever not wrapping add_report_entry in a has_report_entry check? Isn't that redundant given the semantics that you've established where add does nothing if there's already something present?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Statisticsallowed callers to register arbitrarystd::functionformatters viaregister_formatter(). While flexible, this prevented full serialization: lambdas cannot be serialized, soStatistics::serialize()dropped formatter information.This PR replaces dynamic formatters with a closed set of predefined render functions, identified by a new
Statistics::Formatterenum (Default,Bytes,Duration,Ratio,MemCopy,MemAlloc).In addition,
Statisticsis now fully picklable. As a result, thegather_statisticsAPI is removed. Instead,cudf-polarsis responsible for pickling and communicatingStatisticsobjects directly.