Improve non-blocking ucxx::Endpoint::close()#232
Draft
pentschev wants to merge 44 commits intorapidsai:mainfrom
Draft
Improve non-blocking ucxx::Endpoint::close()#232pentschev wants to merge 44 commits intorapidsai:mainfrom
ucxx::Endpoint::close()#232pentschev wants to merge 44 commits intorapidsai:mainfrom
Conversation
A race could cause the `Endpoint::errorCallback` to dereference an already closed and destroyed `ucxx::Endpoint`, leading to segmentation faults and sometimes deadlocks. With the use of a `weak_ptr<Endpoint>` that can be prevented by returning before dereferencing the pointer which should be safe since the owner has already been destroyed anyway.
Additionally comment out use of `dropCanceled()` which is probably now redundant but requires confirmation.
…-ep-close-cancel-new
pentschev
force-pushed
the
non-blocking-ep-close-cancel
branch
from
36159e8 to
f640255
Compare
pentschev
added
feature request
Member
Author
|
/ok to test |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
…cancel-merge-refactor-inflight-requests
…se-cancel-merge-refactor-inflight-requests
Member
Author
|
/ok to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.