[none]: internal imports by default#11
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the InternalImportsByDefault Swift feature and updates numerous module imports to public import across the codebase to maintain public API visibility. A review comment identifies that the NIOHTTP2 import was inadvertently removed from the HTTP/2 connection implementation and should be restored as an internal import.
| import NIOHPACK | ||
| import NIOHTTP2 | ||
| public import NIOCore | ||
| public import NIOHPACK |
There was a problem hiding this comment.
The import of NIOHTTP2 was removed in this file. Since this file defines an HTTP/2 connection, it is highly likely that NIOHTTP2 is still required for the implementation. It should be retained as an internal import (which is the default with the InternalImportsByDefault feature enabled).
Suggested change
| public import NIOHPACK | |
| public import NIOHPACK | |
| import NIOHTTP2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.