Correct script dir#27
Merged
Merged
Conversation
Override bindir and datadir, so that pkgdatadir ends up the same as bindir
lurch
reviewed
May 11, 2026
Comment on lines
+22
to
+23
| cd "$BUILDDIR/$INSTALLDIR/$BINDIR" | ||
| find . -maxdepth 1 ! -name . ! -name .. ! -name openocd ! -name scripts -exec rm -r {} + |
Contributor
There was a problem hiding this comment.
Looking at this change and comparing it to the Mac and Windows scripts, should these lines be above the "# Add libraries..." comment line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overrides OpenOCD paths to ensure
bin2dataends up empty, so it searches the script dir next to the executableFixes #22