Allow annotations on Traefik ingress routes#38
Conversation
|
@TheGoldenPlatypus tagging for visibility |
|
@poissoncorp tagging for visibility |
|
Hey @jkossis, thank you for the PRs. We'll get to the review soon. Let us know if this is currently blocking your RavenDB adoption 🙌 |
|
@poissoncorp it is indeed blocking my current usage. I'm working around it by running my own simple k8s deployment, but using the operator would be ideal obviously. |
poissoncorp
left a comment
There was a problem hiding this comment.
Reviewed: adds a traefik.annotations map on the cluster chart, applied to both generated IngressRouteTCP objects, documented in README + values.yaml. Cleanly scoped, backward-compatible (default dict), and unblocks the external-dns use case without post-install patching. e2e is skipped here as expected (fork PR, secret-gated jobs); runnable checks pass. Thanks @jkossis.
Summary
Use case
When external-dns is configured with the Traefik source, operators often need annotations on the Traefik route objects themselves. For example, Pi-hole or other DNS providers can use:
This lets external-dns discover the generated RavenDB HTTPS and TCP
IngressRouteTCPresources and create DNS records for bothpublicServerUrlandpublicServerUrlTcphostnames without requiring users to patch Helm-managed resources after install.Validation