Skip to content

Allow annotations on Traefik ingress routes#38

Open
jkossis wants to merge 1 commit into
ravendb:mainfrom
jkossis:add-traefik-ingressroute-annotations
Open

Allow annotations on Traefik ingress routes#38
jkossis wants to merge 1 commit into
ravendb:mainfrom
jkossis:add-traefik-ingressroute-annotations

Conversation

@jkossis

@jkossis jkossis commented Jun 25, 2026

Copy link
Copy Markdown

Summary

  • Add traefik.annotations to the cluster chart values
  • Apply those annotations to generated HTTPS and TCP IngressRouteTCP resources
  • Document the new values key in the cluster chart README

Use case

When external-dns is configured with the Traefik source, operators often need annotations on the Traefik route objects themselves. For example, Pi-hole or other DNS providers can use:

traefik:
  annotations:
    external-dns.alpha.kubernetes.io/target: traefik

This lets external-dns discover the generated RavenDB HTTPS and TCP IngressRouteTCP resources and create DNS records for both publicServerUrl and publicServerUrlTcp hostnames without requiring users to patch Helm-managed resources after install.

Validation

  • helm lint helm/cluster-chart
  • helm template ravendb-cluster helm/cluster-chart -n test with traefik.annotations.external-dns.alpha.kubernetes.io/target=traefik

@jkossis

jkossis commented Jun 30, 2026

Copy link
Copy Markdown
Author

@TheGoldenPlatypus tagging for visibility

@jkossis

jkossis commented Jul 10, 2026

Copy link
Copy Markdown
Author

@poissoncorp tagging for visibility

@poissoncorp

Copy link
Copy Markdown
Contributor

Hey @jkossis, thank you for the PRs. We'll get to the review soon. Let us know if this is currently blocking your RavenDB adoption 🙌

@jkossis

jkossis commented Jul 15, 2026

Copy link
Copy Markdown
Author

@poissoncorp it is indeed blocking my current usage. I'm working around it by running my own simple k8s deployment, but using the operator would be ideal obviously.

@poissoncorp poissoncorp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: adds a traefik.annotations map on the cluster chart, applied to both generated IngressRouteTCP objects, documented in README + values.yaml. Cleanly scoped, backward-compatible (default dict), and unblocks the external-dns use case without post-install patching. e2e is skipped here as expected (fork PR, secret-gated jobs); runnable checks pass. Thanks @jkossis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants