fix: hide superseded failure in show api status#92
Merged
Conversation
The status display printed Last Failure whenever it was non-zero, even when a newer success had already cleared the failure on disk. Gate the line on the same "currently failing" check (failure newer than success) the health status already uses, so recovered APIs stop showing stale failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show api statusprintedLast Failurewhenever it was non-zero, so an API that recovered still showed a stale failure older than its last success — the case in the prior write-time fix that on-disk caches predate. Gate the line onfailure.After(success), the same check the health status already uses. Verified:go vetandgo test ./cmd/pass.