feat: emit stored secret on import, drop secrets keyword#96
Merged
Conversation
Import now always emits WLAN secrets so the config is ready to apply: the stored enc: value by default (apply decrypts it), or plaintext with the decrypt keyword. A clear-text cache value or wrong password masks as *secret*. The secrets keyword is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import now always emits WLAN secrets so the file is ready to apply: the stored
enc:value verbatim by default (apply decrypts it), or plaintext with thedecryptkeyword. A clear-text cache value or a wrong decrypt password masks as*secret*. Thesecretskeyword is removed. Verified: against MX-MEX-904EN — default emitsenc:,decryptreturns plaintext,secretsis now rejected; full suite + lint clean.