fix: align refresh board bar, humanize failure rows#98
Merged
Conversation
The done/failed rows padded the status glyph with two spaces while the active row used one, shifting the bar a column. Use one space everywhere. Replace the raw wrapped error on a failed row with a short classified reason (timeout, refused, host not found, auth, TLS) plus the dial target when present; the full error still prints in the command's trailing error block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pad the status glyph with one space on every row so the progress bar lines up (done/failed used two, shifting it a column), and replace the raw wrapped error on a failed row with a short classified reason plus the dial target when present. Full error still prints in the command's trailing error block. Verified: go build/test/lint green; bar-column alignment guarded by test.