Skip to content

fix: make annotateDirtyNodesWithError return new nodes instead of mutating #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Av1ralS1ngh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make annotateDirtyNodesWithError return new nodes instead of mutating #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/lib/graphUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,10 @@ async function loadBackendLimits(baseUrl: string): Promise<BackendLimits> {
function annotateDirtyNodesWithError(
nodes: Node<CalculationNodeData>[],
message: string
) {
nodes.forEach((node) => {
if (node.data?.dirty) {
node.data.error = true;
node.data.extendedError = message;
}
): Node<CalculationNodeData>[] {
return nodes.map((node) => {
if (!node.data?.dirty) return node;
return { ...node, data: { ...node.data, error: true, extendedError: message } };
});
}

Expand Down Expand Up @@ -178,9 +176,8 @@ export async function recalculateGraph(
const limitMessage = `Request is ${formatBytes(
payloadBytes
)}, over the server limit (${formatBytes(maxPayloadBytes)}).`;
annotateDirtyNodesWithError(nodes, limitMessage);
return {
nodes,
nodes: annotateDirtyNodesWithError(nodes, limitMessage),
version,
errors: [{ nodeId: PAYLOAD_LIMIT_NODE_ID, error: limitMessage }],
};
Expand Down Expand Up @@ -223,11 +220,8 @@ export async function recalculateGraph(
? "Backend not running. Start it with: python routes.py"
: "Cannot connect to calculation service. Please try again later.";

// Mark all dirty nodes with error
annotateDirtyNodesWithError(nodes, message);

return {
nodes: nodes,
nodes: annotateDirtyNodesWithError(nodes, message),
version: version,
errors: [], // No system error - the node errors are enough
};
Expand Down