tests: unify DB setup; add TTL & nil-key tests#22
Draft
rawbytedev wants to merge 5 commits into
Draft
Conversation
Replace direct NewBadgerDB/NewPebbleDB calls with fixture.SetupDB and add proper defer db.Close() across tests. Add TTL-related tests for Badger (TestTTTL, TestBatchTTL) and key-nil behavior tests (TestKeyNil) for both implementations, and adjust expectations accordingly (Badger should error on nil key, Pebble should not). Ensure iterators are released via deferred it.Release() and tighten iteration assertions (expect 10 items). Update testing/crud_test.go to close DBs in helper tests and generalize the TestClose error message.
7 tasks
Replace direct NewBadgerDB/NewPebbleDB calls with fixture.SetupDB and add proper defer db.Close() across tests. Add TTL-related tests for Badger (TestTTTL, TestBatchTTL) and key-nil behavior tests (TestKeyNil) for both implementations, and adjust expectations accordingly (Badger should error on nil key, Pebble should not). Ensure iterators are released via deferred it.Release() and tighten iteration assertions (expect 10 items). Update testing/crud_test.go to close DBs in helper tests and generalize the TestClose error message.
Owner
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Add tests for nil key handling across all backends
Test batch operations including failure situations
Validate iterator resource cleanup
Add chaos testing (context cancellation/failure cases)
Implement benchmark reporting in CI
Add performance regression detection
Include cross-platform and matrix testing in CI/CD