[CEPF-1955] Added aouth implementation#428
Conversation
razortanmayshah
left a comment
razortanmayshah
left a comment
There was a problem hiding this comment.
Code Sanity wise looks good to me
| .map(([key, value]) => key === "redirect_uri" | ||
| ? `${key}=${value}` | ||
| : `${key}=${encodeURIComponent(value)}`) | ||
| .flatMap(([key, value]) => |
There was a problem hiding this comment.
why use flatMap instead of map ? can you explain that in a comment
There was a problem hiding this comment.
to handle values like ['read_only', 'read_write'] and map to scope[]=read_only&scope[]=read_write
There was a problem hiding this comment.
please take @shwatang's approval on this
There was a problem hiding this comment.
Discussed over call.
to handle values like ['read_only', 'read_write'] and map to scope[]=read_only&scope[]=read_write
This logic is expected. Though how will this be implemented in JS is something you folks can take a call on.
lib/oAuthTokenClient.js
Outdated
| }, callback) | ||
| } | ||
|
|
||
| validateInput(inputData, schema) { |
There was a problem hiding this comment.
any reason why is this removed ?
There was a problem hiding this comment.
Added in
razortanmayshah
left a comment
razortanmayshah
left a comment
There was a problem hiding this comment.
Approving given @shwatang 's approval on usage of flatMap is there
3 participants
Documentation of end points : https://docs.google.com/document/d/1JP4WAmprhFSQtqWO2VD1jcpU9o-ZEMwWzY81OH9YxV8/edit?usp=sharing
Tech Spec Doc : https://docs.google.com/document/d/1JP4WAmprhFSQtqWO2VD1jcpU9o-ZEMwWzY81OH9YxV8/edit?usp=sharing
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.