test: refine unit test linting#2
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
This PR refines the repo’s test/lint harness to better align with PHPUnit 12 expectations and to keep PHPCS configuration focused on repo structure while moving certain suppressions closer to where the restricted functions are used.
Changes:
- Update PHPUnit testsuite discovery to explicitly include
.phpfiles undertests/Unit(PHPUnit 12 compatibility). - Adjust PHPCS ruleset to lint
tests/Unit, excludetests/bootstrap.php, and relax file-naming sniffs for*Test.phpfiles. - Add PHPCS suppressions in the bump script and unit test to replace previously global ruleset exclusions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/Unit/BumpPluginVersionTest.php | Adds headers/docs and refactors assertions; introduces file-level PHPCS suppressions and a fixture file reader helper. |
| scripts/bump-plugin-version.php | Moves PHPCS suppressions into the script file (instead of global ruleset excludes). |
| phpunit.xml.dist | Tweaks unit testsuite directory config for PHPUnit 12 file discovery behavior. |
| phpcs.xml | Removes global exclusions for certain restricted-function sniffs; adds test-targeted filename exclusions and includes tests/Unit in lint targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the scripts test harness to keep PHPUnit naming compatible with PHPUnit 12, keep fixture specific PHPCS disables next to the code that needs them, and keep the shared ruleset focused on repo structure.