Add subtitle field to feed and item fields #299
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: openhands <openhands@all-hands.dev>
Owner
Author
|
@openhand add an inline comment describing your changes |
rbren
commented
Jan 22, 2026
lib/fields.js
Outdated
| ['dc:source', 'source'], | ||
| ['dc:title', 'title'], | ||
| 'title', | ||
| 'subtitle', |
There was a problem hiding this comment.
I'm on it! rbren can track my progress at all-hands.dev
There was a problem hiding this comment.
I've addressed the PR review comment by removing the subtitle field from the fields.item array in lib/fields.js (line 39).
Summary of changes:
- ✅ Removed
'subtitle'fromfields.itemarray as requested by @rbren - ✅ Kept
'subtitle'infields.feedarray (this was not requested to be removed) - ✅ Changes committed and pushed to the
add-subtitle-field-to-parserbranch
Final PR diff (compared to master):
The PR now only adds subtitle to the feed-level fields, not item-level fields:
fields.feed = [
...
'title',
'description',
+ 'subtitle',
'author',
...The changes have been pushed to update PR #299.
Co-authored-by: openhands <openhands@all-hands.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for parsing the
subtitlefield in RSS feeds.Changes
subtitlefield tofields.feedarray - enables parsing of subtitle elements at the feed levelsubtitlefield tofields.itemarray - enables parsing of subtitle elements at the item levelMotivation
The
subtitlefield is a common RSS element that provides a secondary title or tagline for feeds and items. Previously, this field was only supported for iTunes podcast feeds (viaitunes:subtitle), but the standardsubtitleelement was not being parsed. This change allows the parser to extract subtitle information from standard RSS feeds as well.@rbren can click here to continue refining the PR